pgsql: Improve assertion in FindReplTupleInLocalRel(). - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Improve assertion in FindReplTupleInLocalRel().
Date
Msg-id E1soEYy-000X9P-0b@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve assertion in FindReplTupleInLocalRel().

The first part of the assertion verifying that the passed index must be PK
or RI was incorrectly passing index relation instead of heap relation in
GetRelationIdentityOrPK(). The assertion was not failing because the
second part of the assertion which needs to be performed only when remote
relation has REPLICA_IDENTITY_FULL set was also incorrect.

The change is not backpatched because the current coding doesn't lead to
any failure.

Reported-by: Dilip Kumar
Author: Amit Kapila
Reviewed-by: Vignesh C
Discussion: https://postgr.es/m/CAFiTN-tmguaT1DXbCC+ZomZg-oZLmU6BPhr0po7akQSG6vNJrg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3beb945da9d72a9803180deb1752cf8feeb66883

Modified Files
--------------
src/backend/replication/logical/worker.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Optimize pg_visibility with read streams.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: common/jsonapi: support libpq as a client