pgsql: Don't disallow DROP of constraints ONLY on partitioned tables - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Don't disallow DROP of constraints ONLY on partitioned tables
Date
Msg-id E1svDBn-001YNU-Mc@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't disallow DROP of constraints ONLY on partitioned tables

This restriction seems to have come about due to some fuzzy thinking: in
commit 9139aa19423b we were adding a restriction against ADD constraint
ONLY on partitioned tables (which is sensible) and apparently we thought
the DROP case had to be symmetrical.  However, it isn't, and the
comments about it are mistaken about the effect it would have.  Remove
this limitation.

There have been no reports of users bothered by this limitation, so I'm
not backpatching it just yet.  We can revisit this decision later, as needed.

Reviewed-by: Amit Langote <amitlangote09@gmail.com>
Discussion: https://postgr.es/m/202409261752.nbvlawkxsttf@alvherre.pgsql
Discussion: https://postgr.es/m/7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp
        (about commit 9139aa19423b, previously not registered)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4dea33ce765d65d8807d343ca6535a3d067a63da

Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml         |  4 +++-
src/backend/commands/tablecmds.c          | 38 +------------------------------
src/test/regress/expected/alter_table.out | 21 +++++++++++------
src/test/regress/sql/alter_table.sql      |  7 +++---
4 files changed, 22 insertions(+), 48 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Bump catalog version for change in VariableSetStmt
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Bump MIN_WINNT for MINGW to clear a build error