pgsql: Stabilize the test added by commit 022564f60c. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Stabilize the test added by commit 022564f60c.
Date
Msg-id E1sy4N0-002esR-0Z@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Stabilize the test added by commit 022564f60c.

The test was unstable in branches 14 and 15 as we were relying on the
number of changes in the table having a toast column to start streaming.
On branches >= 16, we have a GUC debug_logical_replication_streaming which
can stream each change, so the test was stable in those branches.

Change the test to use PREPARE TRANSACTION as that should make the result
consistent and test the code changed in 022564f60c.

Reported-by: Daniel Gustafsson as per buildfarm
Author: Hou Zhijie, Amit Kapila
Backpatch-through: 14
Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/581092c9079f78194a4cff757de891fb2027de95

Modified Files
--------------
contrib/test_decoding/expected/stream.out   | 20 --------------------
contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++
contrib/test_decoding/sql/stream.sql        | 18 ------------------
contrib/test_decoding/sql/twophase.sql      | 22 ++++++++++++++++++++++
4 files changed, 45 insertions(+), 38 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Stabilize the test added by commit 022564f60c.
Next
From: Fujii Masao
Date:
Subject: pgsql: Add REJECT_LIMIT option to the COPY command.