pgsql: bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync
Date
Msg-id E1syDWP-002jSA-Rh@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync=off

As pg_flush_data() doesn't do anything with fsync disabled, there's no point
in tracking the buffer for writeback. Arguably the better fix would be to
change pg_flush_data() to flush data even with fsync off, but that's a
behavioral change, whereas this is just a small optimization.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/1f6b50a7-38ef-4d87-8246-786d39f46ab9@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/488f826c729bd570c36df369fa8ac90c9a5a1b46

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Silence buildfarm warning chatter from bd1276a3c.
Next
From: Tom Lane
Date:
Subject: pgsql: Add min and max aggregates for bytea type.