pgsql: Allow pushdown of HAVING clauses with grouping sets - Mailing list pgsql-committers

From Richard Guo
Subject pgsql: Allow pushdown of HAVING clauses with grouping sets
Date
Msg-id E1syRxs-0000Tr-Pz@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow pushdown of HAVING clauses with grouping sets

In some cases, we may want to transfer a HAVING clause into WHERE in
hopes of eliminating tuples before aggregation instead of after.

Previously, we couldn't do this if there were any nonempty grouping
sets, because we didn't have a way to tell if the HAVING clause
referenced any columns that were nullable by the grouping sets, and
moving such a clause into WHERE could potentially change the results.

Now, with expressions marked nullable by grouping sets with the RT
index of the RTE_GROUP RTE, it is much easier to identify those
clauses that reference any nullable-by-grouping-sets columns: we just
need to check if the RT index of the RTE_GROUP RTE is present in the
clause.  For other HAVING clauses, they can be safely pushed down.

Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4-NpzPgtKU=hgnvyn+J-GanxQCjrUi7piNzZ=upiCV=2Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/67a54b9e83d331eadd3a595e6c3bfec06288d2c4

Modified Files
--------------
src/backend/optimizer/plan/planner.c       | 17 +++++++++--------
src/test/regress/expected/groupingsets.out | 21 +++++++++++++++++++++
src/test/regress/sql/groupingsets.sql      |  5 +++++
3 files changed, 35 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Fix mention of AT LOCAL in release notes
Next
From: Michael Paquier
Date:
Subject: pgsql: Apply GUC name from central table in more places of guc.c