pgsql: Avoid possible segfault in psql's tab completion. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid possible segfault in psql's tab completion.
Date
Msg-id E1sz0Ib-000EEu-G8@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid possible segfault in psql's tab completion.

Fix oversight in bd1276a3c: the "words_after_create" stanza in
psql_completion() requires previous_words_count > 0, since it uses
prev_wd.  This condition was formerly assured by the if-else chain
above it, but no more.  If there were no previous words then we'd
dereference an uninitialized pointer, possibly causing a segfault.

Report and patch by Anthonin Bonnefoy.

Discussion: https://postgr.es/m/CAO6_XqrSRE7c_i+D7Hm07K3+6S0jTAmMr60RY41XzaA29Ae5uA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/95eb4cd4ff0648afc32abbfaacc9718f6b91bf7b

Modified Files
--------------
src/bin/psql/tab-complete.in.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Doc: add check to detect non-breaking spaces in the docs.
Next
From: Tatsuo Ishii
Date:
Subject: Re: pgsql: Doc: add check to detect non-breaking spaces in the docs.