pgsql: Simplify call to rebuild relcache entry for indexes - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Simplify call to rebuild relcache entry for indexes
Date
Msg-id E1t6QJ4-003GUO-1S@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Simplify call to rebuild relcache entry for indexes

RelationClearRelation(rebuild == true) calls RelationReloadIndexInfo()
for indexes. We can rely on that in RelationIdGetRelation(), instead
of calling RelationReloadIndexInfo() directly. That simplifies the
code a little.

In the passing, add a comment in RelationBuildLocalRelation()
explaining why it doesn't call RelationInitIndexAccessInfo(). It's
because at index creation, it's called before the pg_index row has
been created. That's also the reason that RelationClearRelation()
still needs a special case to go through the full-blown rebuild if the
index support information in the relcache entry hasn't been populated
yet.

Reviewed-by: jian he <jian.universality@gmail.com>
Discussion: https://www.postgresql.org/message-id/9c9e8908-7b3e-4ce7-85a8-00c0e165a3d6%40iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8e2e2662214a0a6d0fb23a070ea78d691d8ced43

Modified Files
--------------
src/backend/utils/cache/relcache.c | 41 ++++++++++++++++----------------------
1 file changed, 17 insertions(+), 24 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Remove unused field from SubPlanState struct
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Remove duplicate words in comments