pgsql: Optimize grouping equality checks with virtual slots - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Optimize grouping equality checks with virtual slots
Date
Msg-id E1tO4rg-000HH9-1V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Optimize grouping equality checks with virtual slots

8f4ee9626 fixed an old Assert failure that could happen when the slot
type used to look up the hash table for BuildTupleHashTableExt() users
wasn't a TTSOpsMinimalTuple slot.  The fix for that in the back branches
had to be to pass the TupleTableSlotOps as NULL, however in master,
since we have the inputOps parameter as was added by d96d1d515, we can
pass that down instead.

At least one caller uses a fixed slot that's always TTSOpsVirtual, so
passing down inputOps for these cases allows ExecBuildGroupingEqual() to
skip adding the EEOP_INNER_FETCHSOME ExprEvalStep.

This should increase the performance of hashed subplans very slightly.

Author: Tom Lane, David Rowley
Discussion: https://postgr.es/m/2543667.1734483723@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/08cdb079d4a8a82c687321e9ffe0a3d3fbcc0551

Modified Files
--------------
src/backend/executor/execGrouping.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix Assert failure in WITH RECURSIVE UNION queries
Next
From: Michael Paquier
Date:
Subject: pgsql: Extract logic filling pg_stat_get_io()'s tuplestore into its own