pgsql: Don't allow GetTransactionSnapshot() in logical decoding - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Don't allow GetTransactionSnapshot() in logical decoding
Date
Msg-id E1tPfvO-000v3V-Fl@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't allow GetTransactionSnapshot() in logical decoding

A historic snapshot should only be used for catalog access, not
general queries. We never call GetTransactionSnapshot() during logical
decoding, which is good because it wouldn't be very sensible, so the
code to deal with that was unreachable and untested. Turn it into an
error, to avoid doing that in the future either.

Discussion: https://www.postgresql.org/message-id/a868fe78-ddb4-4b0a-9b96-873d91d93cfd@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1585ff7387dbcc5657522b2ed87ffd58fd555ee9

Modified Files
--------------
src/backend/utils/time/snapmgr.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix incorrect source filename references
Next
From: Tom Lane
Date:
Subject: pgsql: postgres_fdw: re-issue cancel requests a few times if necessary.