pgsql: Remove useless check for negative result of ip_addrsize(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove useless check for negative result of ip_addrsize().
Date
Msg-id E1u2wTm-003cyQ-2j@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove useless check for negative result of ip_addrsize().

By inspection, ip_addrsize() can't return a negative result.
(If it could, we'd have way bigger problems elsewhere.)
So delete useless check in network_send().  Most C compilers
are probably perfectly capable of removing this code by
themselves, but it's confusing/misleading.

Bug: #18889
Reported-by: Daniel Elishakov <dan-eli@mail.ru>
Discussion: https://postgr.es/m/18889-73d4f19e953a629e@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f27eb0325b7b2cff3b880fa669913693849521dc

Modified Files
--------------
src/backend/utils/adt/network.c | 2 --
1 file changed, 2 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Further cleanup for directory creation on pg_dump/pg_dumpall
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: remove long-obsolete advice about generated constraint name