pgsql: oauth: Fix kqueue detection on OpenBSD - Mailing list pgsql-committers

From Jacob Champion
Subject pgsql: oauth: Fix kqueue detection on OpenBSD
Date
Msg-id E1uYsfb-005AB0-1n@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
oauth: Fix kqueue detection on OpenBSD

In b0635bfda, I added an early header check to the Meson OAuth support,
which was intended to duplicate the later checks for
HAVE_SYS_[EVENT|EPOLL]_H. However, I implemented the new test via
check_header() -- which tries to compile -- rather than has_header(),
which just looks for the file's existence.

The distinction matters on OpenBSD, where <sys/event.h> can't be
compiled without including prerequisite headers, so -Dlibcurl=enabled
failed on that platform. Switch to has_header() to fix this.

Note that reviewers expressed concern about the difference between our
Autoconf feature tests (which compile headers) and our Meson feature
tests (which do not). I'm not opposed to aligning the two, but I want to
avoid making bigger changes as part of this fix.

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/flat/CAOYmi+kdR218ke2zu74oTJvzYJcqV1MN5=mGAPqZQuc79HMSVA@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7376e6085468054328a66e8c10c007bdaaf88f91

Modified Files
--------------
meson.build | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Jacob Champion
Date:
Subject: pgsql: oauth: Fix kqueue detection on OpenBSD
Next
From: Richard Guo
Date:
Subject: pgsql: Consider explicit incremental sort for Append and MergeAppend