pgsql: Fix low-probability memory leak in XMLSERIALIZE(... INDENT). - Mailing list pgsql-committers

Fix low-probability memory leak in XMLSERIALIZE(... INDENT).

xmltotext_with_options() did not consider the possibility that
pg_xml_init() could fail --- most likely due to OOM.  If that
happened, the already-parsed xmlDoc structure would be leaked.
Oversight in commit 483bdb2af.

Bug: #18981
Author: Dmitry Kovalenko <d.kovalenko@postgrespro.ru>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/18981-9bc3c80f107ae925@postgresql.org
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e03c95287764158941d317972a332565729b6af2

Modified Files
--------------
src/backend/utils/adt/xml.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)