pgsql: pg_dump: Fix object-type sort priority for large objects. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: pg_dump: Fix object-type sort priority for large objects.
Date
Msg-id E1uZyHV-005dlk-22@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_dump: Fix object-type sort priority for large objects.

Commit a45c78e328 moved large object metadata from SECTION_PRE_DATA
to SECTION_DATA but neglected to move PRIO_LARGE_OBJECT in
dbObjectTypePriorities accordingly.  While this hasn't produced any
known live bugs, it causes problems for a proposed patch that
optimizes upgrades with many large objects.  Fixing the priority
might also make the topological sort step marginally faster by
reducing the number of ordering violations that have to be fixed.

Reviewed-by: Nitin Motiani <nitinmotiani@google.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/aBkQLSkx1zUJ-LwJ%40nathan
Discussion: https://postgr.es/m/aG_5DBCjdDX6KAoD%40nathan
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e43fae199e5068914c6cc39aff9dbbb65aa896d7

Modified Files
--------------
src/bin/pg_dump/pg_dump_sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix sslkeylogfile error handling logging