Restrict psql meta-commands in plain-text dumps.
A malicious server could inject psql meta-commands into plain-text
dump output (i.e., scripts created with pg_dump --format=plain,
pg_dumpall, or pg_restore --file) that are run at restore time on
the machine running psql. To fix, introduce a new "restricted"
mode in psql that blocks all meta-commands (except for \unrestrict
to exit the mode), and teach pg_dump, pg_dumpall, and pg_restore to
use this mode in plain-text dumps.
While at it, encourage users to only restore dumps generated from
trusted servers or to inspect it beforehand, since restoring causes
the destination to execute arbitrary code of the source superusers'
choice. However, the client running the dump and restore needn't
trust the source or destination superusers.
Reported-by: Martin Rakhmanov
Reported-by: Matthieu Denais <litezeraw@gmail.com>
Reported-by: RyotaK <ryotak.mail@gmail.com>
Suggested-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Security: CVE-2025-8714
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7ad8e790988d3a49010ec00e0cec0dace4c7416f
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 35 ++++++++++++
doc/src/sgml/ref/pg_dumpall.sgml | 30 ++++++++++
doc/src/sgml/ref/pg_restore.sgml | 34 +++++++++++
doc/src/sgml/ref/pgupgrade.sgml | 8 +++
doc/src/sgml/ref/psql-ref.sgml | 36 ++++++++++++
src/bin/pg_dump/dumputils.c | 38 +++++++++++++
src/bin/pg_dump/dumputils.h | 3 +
src/bin/pg_dump/pg_backup.h | 4 ++
src/bin/pg_dump/pg_backup_archiver.c | 32 ++++++++++-
src/bin/pg_dump/pg_dump.c | 21 +++++++
src/bin/pg_dump/pg_dumpall.c | 36 ++++++++++++
src/bin/pg_dump/pg_restore.c | 22 ++++++++
src/bin/pg_dump/t/002_pg_dump.pl | 19 +++++--
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 2 +
src/bin/psql/command.c | 94 ++++++++++++++++++++++++++++++-
src/bin/psql/help.c | 4 ++
src/bin/psql/t/001_basic.pl | 7 +++
src/bin/psql/tab-complete.c | 4 +-
src/test/recovery/t/027_stream_regress.pl | 4 ++
src/test/regress/expected/psql.out | 2 +
src/test/regress/sql/psql.sql | 2 +
21 files changed, 427 insertions(+), 10 deletions(-)
