pgsql: pg_restore: Fix comment handling with --no-policies. - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: pg_restore: Fix comment handling with --no-policies.
Date
Msg-id E1uyLre-000vmn-2M@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_restore: Fix comment handling with --no-policies.

Previously, pg_restore did not skip comments on policies even when
--no-policies was specified. As a result, it could issue COMMENT commands
for policies that were never created, causing those commands to fail.

This commit fixes the issue by ensuring that comments on policies
are also skipped when --no-policies is used.

Backpatch to v18, where --no-policies was added in pg_restore.

Author: Jian He <jian.universality@gmail.com>
Co-authored-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2ddbfede0c615c009bbbb0f8dfcaa848da5d2376

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c |  7 +++++-
src/bin/pg_dump/t/002_pg_dump.pl     | 46 ++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: pg_restore: Fix comment handling with --no-policies.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix incorrect const qualifier