pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve
Date
Msg-id E1uyQT0-000y2m-26@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_dump: Fix dumping of security labels on subscriptions and event triggers.

Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels
for subscriptions, which are stored in pg_shseclabel as they are global objects.
This could result in security labels for subscriptions not being dumped.

This commit fixes the issue by updating pg_dump to query the pg_seclabels view,
which aggregates entries from both pg_seclabel and pg_shseclabel.
While querying pg_shseclabel directly for subscriptions was an alternative,
using pg_seclabels is simpler and sufficient.

In addition, pg_dump is updated to dump security labels on event triggers,
which were previously omitted.

Backpatch to all supported versions.

Author: Jian He <jian.universality@gmail.com>
Co-authored-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dff7591a7041b4ccbb42806c6492a29d86fece86

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++-----
src/bin/pg_dump/pg_dump.c            |  7 ++++++-
2 files changed, 13 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Move pg_int64 back to postgres_ext.h