pgsql: Tighten check for generated column in partition key expression - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Tighten check for generated column in partition key expression
Date
Msg-id E1vGIEp-0050Jb-1K@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tighten check for generated column in partition key expression

A generated column may end up being part of the partition key
expression, if it's specified as an expression e.g. "(<generated
column name>)" or if the partition key expression contains a whole-row
reference, even though we do not allow a generated column to be part
of partition key expression.  Fix this hole.

Co-authored-by: jian he <jian.universality@gmail.com>
Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com>
Discussion:
https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7180d56c5609166ac9bd7203e7ac0ad50bf400ce

Modified Files
--------------
src/backend/commands/tablecmds.c        | 86 ++++++++++++++++++---------------
src/test/regress/expected/generated.out | 15 ++++++
src/test/regress/sql/generated.sql      |  3 ++
3 files changed, 66 insertions(+), 38 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Tighten check for generated column in partition key expression
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Have psql's "\? variables" show csv_fieldsep