pgsql: Introduce XLogRecPtrIsValid() - Mailing list pgsql-committers

From Álvaro Herrera
Subject pgsql: Introduce XLogRecPtrIsValid()
Date
Msg-id E1vH4c1-005KaY-1c@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Introduce XLogRecPtrIsValid()

XLogRecPtrIsInvalid() is inconsistent with the affirmative form of
macros used for other datatypes, and leads to awkward double negatives
in a few places.  This commit introduces XLogRecPtrIsValid(), which
allows code to be written more naturally.

This patch only adds the new macro.  XLogRecPtrIsInvalid() is left in
place, and all existing callers remain untouched.  This means all
supported branches can accept hypothetical bug fixes that use the new
macro, and at the same time any code that compiled with the original
formulation will continue to silently compile just fine.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Backpatch-through: 13
Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/20bafb0972882eaf0fb50349fc4023e1e5505a57

Modified Files
--------------
src/include/access/xlogdefs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Refer readers of \? to "\? variables" for pset options
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Use XLogRecPtrIsValid() in various places