> On 29 Oct 2024, at 12:54, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> I made a patch for this. I have expanded the narrative discussion on what commands are supported for event triggers,
alsomade a few corrections/additions there, based on inspecting the source code. And then removed the big matrix,
whichdoesn't provide any additional information, I think.
>
> I think this is sufficient and covers everything. The only hand-wavy thing I can see is exactly which ALTER commands
triggerthe sql_drop event. But this was already quite imprecise before, and I think also not quite correct. This
mightneed a separate investigation.
>
> In any case, we can use this as a starting point to iterate on the right wording etc.
+1, I think this is a net improvement.
The only thing I would change on top of this is move the reference to section
9.30 under table_rewrite to be at the end after both supporting functions since
the link is relevant to both of them. Something like:
- <literal>pg_event_trigger_table_rewrite_oid()</literal> (see
- <xref linkend="functions-event-triggers"/>). To discover the reason(s)
- for the rewrite, use the function
- <literal>pg_event_trigger_table_rewrite_reason()</literal>.
+ <literal>pg_event_trigger_table_rewrite_oid()</literal> To discover the reason(s)
+ for the rewrite, use the function <literal>pg_event_trigger_table_rewrite_reason()</literal>
+ (see <xref linkend="functions-event-triggers"/>).
--
Daniel Gustafsson
