Re: [PATCH] Add tests for Bitmapset - Mailing list pgsql-hackers

On Sep 17 2025, at 9:55 am, Robert Haas <robertmhaas@gmail.com> wrote:

> On Wed, Sep 17, 2025 at 9:18 AM Greg Burd <greg@burd.me> wrote:
>> > +static void
>> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
>> >
>>
>> I added a function bms_values() that prints out the values contained in
>> a bitmapset and changed a few tests to use it.  I removed the
>> elog_bitmapset() as it isn't being used and now that it's easy to output
>> the set in SQL why keep it for debugging?
>
> How about using outBitmapset() which already exists?

Robert,

Thanks for chiming in, not sure how I missed that one. :)

> --
> Robert Haas
> EDB: http://www.enterprisedb.com

I've updated the hash value for 32bit systems and changed the
bms_values() function to use outBitmapset() via bmsToString().

best.

-greg