Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Japin Li
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id MEAPR01MB3031127CF9A8C02399E2D0ABB68FA@MEAPR01MB3031.ausprd01.prod.outlook.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
On Sun, 11 Jan 2026 at 21:43, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill@gmail.com> wrote:
>> 
>> So,
>> v14-0004 with this change attached.
>
> Did you mean 0003?
>
> The change makes sense, but I'd note that macro is always used like this:
>
> if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))
>
> If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?
>

+1

Attach the v15 patch.
v15-0001 and v15-0002 unchanged and v15-0003 changed as above.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.


Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Chao Li
Date:
Subject: Re: Buffer locking is special (hints, checksums, AIO writes)