Hi, Roman Khapov
On Mon, 12 Jan 2026 at 01:36, Roman Khapov <rkhapov@yandex-team.ru> wrote:
> Hi!
> Thanks for your review!
>
> We discussed offline about the patch, and I decided to make a review of it and fixes
> up to your comments.
>
Thank you for updating the patches.
>>
>> v2026-01-10-0001
>> ================
>>
>> 1.
>> I'm pretty sure access/heaptoast.h is not needed by verify_nbtree.c.
>>
>
> In fact this include is necessary because of line verify_common.c:236 which
> uses TOAST_INDEX_TARGET
>
Yeah, verify_common.c does require the header, but what I meant was that
verify_nbtree.c no longer needs it.
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index c1e24338361..426e23d2960 100644
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -23,7 +23,6 @@
*/
#include "postgres.h"
-#include "access/heaptoast.h"
#include "access/htup_details.h"
#include "access/nbtree.h"
#include "access/table.h"
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
