Fix redundant comments in fmgr.c - Mailing list pgsql-hackers

From houzj.fnst@fujitsu.com
Subject Fix redundant comments in fmgr.c
Date
Msg-id OS0PR01MB5716405E2464D85E6DB6DC0794469@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: Fix redundant comments in fmgr.c
List pgsql-hackers

Hi,

 

I found some possible redundant comments in fmgr.c

 

1.

fmgr_symbol(Oid functionId, char **mod, char **fn)

{

              HeapTuple          procedureTuple;

              Form_pg_proc procedureStruct;

              bool                     isnull;

              Datum                 prosrcattr;

            Datum                 probinattr;

-             /* Otherwise we need the pg_proc entry */

              procedureTuple = SearchSysCache1(PROCOID, ObjectIdGetDatum(functionId));

 

I guess the comment here was miscopied from fmgr_info_cxt_security:

 

 

 

2.

              if (!HeapTupleIsValid(procedureTuple))

                          elog(ERROR, "cache lookup failed for function %u", functionId);

            procedureStruct = (Form_pg_proc) GETSTRUCT(procedureTuple);

-             /*

-             */

 

Best regards,

houzj

 

 

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: TRUNCATE on foreign table
Next
From: Simon Riggs
Date:
Subject: Docs for lock level of ALTER TABLE .. VALIDATE