Postgres Pro
Downloads
Home   >   mailing lists

RE: Disallow changing slot's failover option in transaction block - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Disallow changing slot's failover option in transaction block
Date
Msg-id OSBPR01MB2552A17F786761759ED149A9F50D2@OSBPR01MB2552.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: Disallow changing slot's failover option in transaction block  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
Responses RE: Disallow changing slot's failover option in transaction block
List pgsql-hackers
Tree view 
Dear Hou,

Thanks for updating the patch! Let me confirm the content.

In your patch, the pg_dump.c was updated. IIUC the main reason was that
pg_restore executes some queries as single transactions so that ALTER
SUBSCRIPTION cannot be done, right?
Also, failover was synchronized only when we were in the upgrade mode, but
your patch seems to remove the condition. Can you clarify the reason?

Other than that, the patch LGTM.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Speed up clean meson builds by ~25%
Next
From: Andres Freund
Date:
Subject: Re: ECPG cleanup and fix for clang compile-time problem