RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date
Msg-id OSCPR01MB14966C184318EA5F21823F9DFF5C92@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.  (Shubham Khanna <khannashubham1197@gmail.com>)
Responses Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
List pgsql-hackers
Dear Shubham,

I did a quick check and have a comment in drop_publication().

```
+    /* For cleanup purposes */
+    dbinfos.dbinfo->made_publication = true;
+
```

Please do not modify randomly. Currently, made_publication is set to false when
the command fails. No need to set to true here - Please follow that. Also, please
do not remove comments within the if statement.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: pg_stat_statements and "IN" conditions
Next
From: Sergey Dudoladov
Date:
Subject: Re: Add connection active, idle time to pg_stat_activity