RE: Logical Replication of sequences - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: Logical Replication of sequences
Date
Msg-id TY4PR01MB16907A2DDF2D7FC41909BCF9E94EBA@TY4PR01MB16907.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Logical Replication of sequences  (shveta malik <shveta.malik@gmail.com>)
List pgsql-hackers
On Monday, October 13, 2025 3:28 PM shveta malik <shveta.malik@gmail.com> wrote:
> Please find few initial comments for 002:

Thanks for the comments.

> 
> 
> 5)
> CheckSubscriptionRelkind
> + if (pubrelkind == '\0')
> + return;
> 
> Do you think, we shall write a comment in the function header that the caller
> who wants to verify only the supported type should pass pubrelkind as '\0'?

This check is removed due to some other changes.

All other comments have been addressed in the latest version.

Best Regards,
Hou zj

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Logical Replication of sequences
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Logical Replication of sequences