RE: Allow escape in application_name - Mailing list pgsql-hackers

From kuroda.hayato@fujitsu.com
Subject RE: Allow escape in application_name
Date
Msg-id TYAPR01MB586659CFEFDD2BD29941987AF5789@TYAPR01MB5866.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Allow escape in application_name  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Allow escape in application_name
List pgsql-hackers
Dear Fujii-san,

Sorry I forgot replying your messages.

> >>             if (strcmp(keywords[i], "application_name") == 0 &&
> >>                 values[i] != NULL && *(values[i]) != '\0')
> >
> > I'm not sure but do we have a case that values[i] becomes NULL
> > even if keywords[i] is "application_name"?
> 
> No for now, I guess. But isn't it safer to check that, too? I also could not find strong
> reason why that check should be dropped. But you'd like to drop that?

No, I agreed the new checking. I'm just afraid of my code missing.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: WIP: WAL prefetch (another approach)
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Allow escape in application_name