Re: Add LZ4 compression in pg_dump - Mailing list pgsql-hackers

From gkokolatos@pm.me
Subject Re: Add LZ4 compression in pg_dump
Date
Msg-id Y15gcrC3SU2y5u63cE3p9APTZ-s6aOoeIu1MX29nVycUpq0l7dss7chpw1P7jdB5Nrs49KwabqdlW1Q50ApVd9GuxLUtFsI-MmQq7ZCY-H8=@pm.me
Whole thread Raw
In response to Re: Add LZ4 compression in pg_dump  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add LZ4 compression in pg_dump
Re: Add LZ4 compression in pg_dump
List pgsql-hackers



On Sat, May 6, 2023 at 04:51, Michael Paquier <michael@paquier.xyz> wrote:
On Fri, May 05, 2023 at 02:13:28PM +0000, gkokolatos@pm.me wrote:
> Good point. I thought about it before submitting the patch. I
> concluded that given the complexity and operations involved in
> LZ4Stream_read_internal() and the rest of t he pg_dump/pg_restore
> code, the memset() call will be negligible. However from the
> readability point of view, the function is a bit cleaner with the
> memset().
>
> I will not object to any suggestion though, as this is a very
> trivial point. Please find attached a v2 of the patch following the
> suggested approach.

Please note that an open item has been added for this stuff.
Thank you but I am not certain I know what that means. Can you please explain?

Cheers,
//Georgios
--
Michael

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Missing update of all_hasnulls in BRIN opclasses
Next
From: Tom Lane
Date:
Subject: Re: MERGE lacks ruleutils.c decompiling support!?