Supporting non-deterministic collations with tailoring rules. - Mailing list pgsql-hackers

From Todd Lang
Subject Supporting non-deterministic collations with tailoring rules.
Date
Msg-id YT2PPF959236618377A072745A280E278F4BE1DA@YT2PPF959236618.CANPRD01.PROD.OUTLOOK.COM
Whole thread Raw
Responses Re: Supporting non-deterministic collations with tailoring rules.
List pgsql-hackers

 

 

Reposting this here from the Discord server as requested:

 

When creating a collation, in https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/pg_locale_icu.c#L461 it is opening the collator with the tailoring rules supplied. However, it has hardcoded the strength level UCOL_DEFAULT_STRENGTH. This has the effect of ignoring the "deterministic=false" you may have specified in your CREATE COLLATION call. If, instead of UCOL_DEFAULT_STRENGTH, the code understood the deterministic parameter and passed either UCOL_PRIMARY for "deterministic=true", and UCOL_SECONDARY for "deterministic=false", this would preserve the attempt to obtain case-insensitivity in the locale while simultaneously allowing tailoring as expected.

 

I have made the modification to the pg_locale_icu.c and tested it locally (simply hardcoding UCOL_SECONDARY – not checking the deterministic parameter) and it behaves as expected, though I freely admit my knowledge of ICU intersecting with Postgres is rather limited.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Next
From: "蔡梦娟(玊于)"
Date:
Subject: Re: Newly created replication slot may be invalidated by checkpoint