Hi,
On Wed, Jan 15, 2025 at 11:09:00AM -0600, Sami Imseih wrote:
> > Appart from the above that LGTM.
>
> thanks! I took care of your comments.
Thanks!
> I was not sure
> about the need to cast "double" but as you mention this
> is consistent with other parts of pgstatfuncs.c
Yup.
> v4 attached.
One comment:
+ PG_RETURN_FLOAT8(result); \
The "\" indentation looks wrong for this line (was ok in v3).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
