Re: attndims, typndims still not enforced, but make the value within a sane threshold - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date
Msg-id Z5FHtmhRWkLLUQL7@momjian.us
Whole thread Raw
In response to Re: attndims, typndims still not enforced, but make the value within a sane threshold  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Jan 21, 2025 at 03:23:31PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I did write a patch in Novemer 2023 to pass the dimension to the layers
> > that needed it, but it was considered too much code compared to its
> > value:
> >     https://www.postgresql.org/message-id/ZVwI_ozT8z9MCnIZ@momjian.us
> 
> Ah, I'd forgotten that discussion.  It looks like the main differences
> between your patch and mine are
> 
> (1) you did nothing about getting a nonzero attndims value for views
> and CREATE TABLE AS cases.
> 
> (2) you found a way to get pg_dump to preserve attndims, which you
> then also applied to psql's \d.

Yes, I was more focused on perserving the value, rather than computing
zero/non-zero from the data type.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Next
From: Noah Misch
Date:
Subject: Re: Issue with markers in isolation tester? Or not?