Re: Another incorrect comment for pg_stat_statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Another incorrect comment for pg_stat_statements
Date
Msg-id ZJvbkLdx5cqXBJGl@paquier.xyz
Whole thread Raw
In response to Re: Another incorrect comment for pg_stat_statements  (Japin Li <japinli@hotmail.com>)
Responses Re: Another incorrect comment for pg_stat_statements
List pgsql-hackers
On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> -        /* Remove the key if it exists, starting with the top-level entry  */
> +        /* Remove the key if it exists, starting with the non-top-level entry */
>          key.toplevel = false;
>          entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
>          if (entry)                /* found */

Nice catch.  That's indeed wrong.  Will fix.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Assert !bms_overlap(joinrel->relids, required_outer)
Next
From: Richard Guo
Date:
Subject: Re: Another incorrect comment for pg_stat_statements