Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Date
Msg-id ZKIhpBreDS7OWnfq@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
List pgsql-hackers
On Fri, Jun 30, 2023 at 09:42:13AM +0200, Daniel Gustafsson wrote:
> Agreed, I'd prefer all branches to work the same for this.

Thanks, done this way across all the branches, then.

> Reading the patch, only one thing stood out:
>
> -variable PG_TEST_NOCLEAN is set, data directories will be retained
> -regardless of test status.
> +variable PG_TEST_NOCLEAN is set, those directories will be retained
>
> I would've written "the data directories" instead of "those directories" here.

Adjusted that as well, on top of an extra comment.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Remove WindowClause PARTITION BY items belonging to redundant pathkeys
Next
From: Masahiko Sawada
Date:
Subject: Re: Skip collecting decoded changes of already-aborted transactions