Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche() - Mailing list pgsql-hackers

From Michael Paquier
Subject Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche()
Date
Msg-id ZMM07Bw8ZvSQ4hJp@paquier.xyz
Whole thread Raw
Responses Re: Add assertion on held AddinShmemInitLock in GetNamedLWLockTranche()
List pgsql-hackers
Hi all,

While digging into the LWLock code, I have noticed that
GetNamedLWLockTranche() assumes that its caller should hold the LWLock
AddinShmemInitLock to prevent any kind of race conditions when
initializing shmem areas, but we don't make sure that's the case.

The sole caller of GetNamedLWLockTranche() in core respects that, but
out-of-core code may not be that careful.  How about adding an
assertion based on LWLockHeldByMeInMode() to make sure that the
ShmemInit lock is taken when this routine is called, like in the
attached?

Thanks,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Support worker_spi to execute the function dynamically.
Next
From: Alexander Lakhin
Date:
Subject: Re: Postgres v15 windows bincheck regression test failures