Re: should frontend tools use syncfs() ? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: should frontend tools use syncfs() ?
Date
Msg-id ZOQUSbi8bD1nhxb4@paquier.xyz
Whole thread Raw
In response to Re: should frontend tools use syncfs() ?  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: should frontend tools use syncfs() ?
List pgsql-hackers
On Mon, Aug 21, 2023 at 06:44:07PM -0700, Nathan Bossart wrote:
> I'm hoping there's a simpler path forward here.  pg_rewind only needs the
> following lines from fd.h:
>
>     /* Filename components */
>     #define PG_TEMP_FILES_DIR "pgsql_tmp"
>     #define PG_TEMP_FILE_PREFIX "pgsql_tmp"
>
> Maybe we could move these to file_utils.h instead.  WDYT?

I guess so..  At the same time, something can be said about
pg_checksums that redeclares PG_TEMP_FILE_PREFIX and PG_TEMP_FILES_DIR
because it does not want to include fd.h and its sync routines.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Nathan Bossart
Date:
Subject: Re: should frontend tools use syncfs() ?