Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()
Date
Msg-id ZRPi9xOBFoTJ5rTb@paquier.xyz
Whole thread Raw
In response to pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()  (Jakub Wartak <jakub.wartak@enterprisedb.com>)
Responses Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()
Re: pg_stat_get_activity(): integer overflow due to (int) * (int) for MemoryContextAllocHuge()
List pgsql-hackers
Tree view 
On Wed, Sep 27, 2023 at 08:41:55AM +0200, Jakub Wartak wrote:
> Attached patch adjusts pgstat_track_activity_query_size to be of
> size_t from int and fixes the issue.

This cannot be backpatched, and using size_t is not really needed as
track_activity_query_size is capped at 1MB.  Why don't you just tweak
the calculation done in pgstat_read_current_status() instead, say with
a cast?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: make add_paths_to_append_rel aware of startup cost
Next
From: Daniel Gustafsson
Date:
Subject: Re: logfmt and application_context