Re: Add lookup table for replication slot invalidation causes - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add lookup table for replication slot invalidation causes
Date
Msg-id ZdbwCVjCfFdbV7oa@paquier.xyz
Whole thread Raw
In response to Re: Add lookup table for replication slot invalidation causes  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Add lookup table for replication slot invalidation causes
Re: Add lookup table for replication slot invalidation causes
List pgsql-hackers
On Thu, Feb 22, 2024 at 05:30:08PM +1100, Peter Smith wrote:
> Oops. Perhaps I meant more like below -- in any case, the point was
> the same -- to ensure RS_INVAL_NONE is what returns if something
> unexpected happens.

You are right that this could be a bit confusing, even if we should
never reach this state.  How about avoiding to return the index of the
loop as result, as of the attached?  Would you find that cleaner?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: Andrei Lepikhov
Date:
Subject: Re: POC: GROUP BY optimization