Re: pgsql: Move code for backend startup to separate file - Mailing list pgsql-committers

Hi Heikki,
(Peter E. in CC.)

On Mon, Mar 18, 2024 at 09:40:36AM +0000, Heikki Linnakangas wrote:
> Move code for backend startup to separate file
>
> This is code that runs in the backend process after forking, rather
> than postmaster. Move it out of postmaster.c for clarity.
>
> Reviewed-by: Tristan Partin, Andres Freund
> Discussion: https://www.postgresql.org/message-id/7a59b073-5b5b-151e-7ed3-8b01ff7ce9ef@iki.fi

--- a/src/include/postmaster/postmaster.h
+++ b/src/include/postmaster/postmaster.h
@@ -52,6 +52,8 @@ extern PGDLLIMPORT int postmaster_alive_fds[2];

 extern PGDLLIMPORT const char *progname;

+extern bool LoadedSSL;

This variable is missing a PGDLLIMPORT, it seems.

aafc05de1bf5 has missed a second one with MyClientSocket.  Both are
declared in postmaster.h.

The credit goes to Peter Eisentraunt for noticing these two who has
mentioned that to me on mastodon, while I am not able to parse
correctly a set of diffs.  This stuff can be spotted with a command
like this one:
src/tools/mark_pgdllimport.pl $(git ls-files *.h)

Thanks,
--
Michael