Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly - Mailing list pgsql-bugs

From Alexander Lakhin
Subject Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Date
Msg-id a8d43cee-aa0d-7962-8fb0-0fcfa9a422ba@gmail.com
Whole thread Raw
In response to Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
List pgsql-bugs
Hello Michael,
06.08.2019 9:21, Michael Paquier wrote:
> On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
>> In case this bug is worth fixing, please look at the improved patch with
>> the corresponding regression test.
> In this case, DecodeSpecial() decodes the abbrevation passed down as
> UNITS, which is right on its own.  Still, afterwards the code fails to
> correctly set a date from the string present.  In short, your
> suggestion of fix looks good to me and that's more consistent with the
> full timezone spec case.  The test case you added in this patch
> triggers the error in the code path where the timezone is not
> specified.  Could you add an extra test case for the timezone
> abbreviation?
Sure, please look at the improved fix.

Best regards,
Alexander

Attachment

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: BUG #15939: Postgres database size is growing due to oraphanobjects
Next
From: Alexander Lakhin
Date:
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly