On 4/23/25 09:41, Frédéric Yhuel wrote:
>
>
> On 4/22/25 19:37, Sami Imseih wrote:
>> the patch relies on looking up queryDesc->sourceText inside DropPortal,
>> which Tom raised concerns about earlier in the thread [0]
>
> Yes, I think I had misunderstood what Tom said. Thank you for pointing
> that out.
>
> However, is it really unsafe?
>
> In exec_bind_message, the portal's query string comes from a duplicate
> of the original string (see CreateCachedPlan). So we are safe in this case.
>
> In exec_simple_query, the portal is dropped towards the end of this
> function, so we are safe here too.
>
> Am I missing something?
Note: the patch doesn't work well with server-side prepared statements:
the PREPARE query is blamed instead of the EXECUTE one. But this is
maybe something that can be fixed easily.
