Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date
Msg-id aKJ9kBZi6gFGvzS5@paquier.xyz
Whole thread Raw
In response to Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
List pgsql-hackers
On Mon, Aug 18, 2025 at 12:56:02PM +1200, David Rowley wrote:
> One last thing, in order to inform people of breakages sooner than a
> post-commit report from the buildfarm, I wondered is if we should do:
>
> -#ifdef HASH_DEBUG
> +#if defined(HASH_DEBUG) || defined(USE_ASSERT_CHECKING)
>
> The HASH_DEBUG does not add any extra fields, so the overhead only
> amounts to the elog(DEBUG4) line.  HASH_STATISTICS adds extra fields
> and counter incrementing, so I don't propose the same treatment for
> that.

If we do that, I guess that we could just remove HASH_DEBUG, keeping
only HASH_STATISTICS.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Next
From: David Rowley
Date:
Subject: Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options