Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date
Msg-id aKK0y03DqwAY7N6k@paquier.xyz
Whole thread Raw
In response to Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
List pgsql-hackers
On Mon, Aug 18, 2025 at 02:19:06PM +1200, David Rowley wrote:
> On Mon, 18 Aug 2025 at 13:26, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, it's really quite unclear what the existing HASH_DEBUG printout
>> is good for.  At least in our usage, it doesn't tell you anything
>> you can't discover from static code analysis.  I'm +1 for just
>> dropping it altogether.
>
> I'm starting to lean more towards that myself. I had mostly just been
> motivated to finding a way to prevent it from existing in a broken
> state again.

+1.

> HASH_STATISTICS I can imagine is more useful as that information isn't
> otherwise recorded anywhere.

By the way, once we have reached a conclusion here, I'll go update one
of my animals to use what's remaining of the flags, so as this is
captured in the future.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: John Naylor
Date:
Subject: Re: GB18030-2022 Support in PostgreSQL