On Wed, Sep 10, 2025 at 05:36:48PM +0500, Andrey Borodin wrote:
> Proposed change is correct and in line with a description of
> e.g. XLOG_HASH_MOVE_PAGE_CONTENTS.
> I'd note that block is for lock only and record does not include
> image, but other such cases are not reported in comments.
Right, the case of block 0 being registered in a MOVE_PAGE_CONTENTS
record to ensure that a cleanup lock is taken is documented in
_hash_squeezebucket()@hashovfl.c, for SQUEEZE_PAGE, or for DELETE.
Squeeze can also do that for buffer 1.
On top of your suggestions, I have double-checked the rest of the hash
records, and they seem to be in line with hash_xlog.h. Will fix,
thanks.
--
Michael
