Re: Incorrect logic in XLogNeedsFlush() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect logic in XLogNeedsFlush()
Date
Msg-id aMtCNJiJvg9WNdHD@paquier.xyz
Whole thread Raw
In response to Re: Incorrect logic in XLogNeedsFlush()  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect logic in XLogNeedsFlush()
Re: Incorrect logic in XLogNeedsFlush()
List pgsql-hackers
On Tue, Sep 16, 2025 at 09:40:50AM +0900, Michael Paquier wrote:
> As a whole, the patch looks like a good balance, able to satisfy the
> new case you want to handle, Melanie.  I am guessing that you'd want
> to tweak it and apply it yourself, so please feel free.

Hearing nothing, I'd like to move ahead with this improvement.  I have
tweaked a bit the comments, as suggested.  If one switches the check
of XLogNeedsFlush() from XLogInsertAllowed() to RecoveryInProgress(),
the recovery test 015 blows up as expected.

Any opinions or more word-smithing required?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Parallel heap vacuum
Next
From: Andres Freund
Date:
Subject: Re: Parallel heap vacuum