Request a Demo
Home   >   mailing lists

Re: Clarification on Role Access Rights to Table Indexes - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Clarification on Role Access Rights to Table Indexes
Date
Msg-id aOfXNAFkj_EFm-8q@nathan
Whole thread Raw
In response to Re: Clarification on Role Access Rights to Table Indexes  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: Clarification on Role Access Rights to Table Indexes
List pgsql-hackers
Tree view 
On Wed, Oct 08, 2025 at 08:28:01PM -0700, Jeff Davis wrote:
> Actually, now I'm unsure. v4-0001 is taking a lock on the table before
> checking privileges, whereas v4-0002 is going to some effort to avoid
> that. Is that because the latter is taking a ShareLock?

I was confused by this, too.  We seem to go to great lengths to avoid
taking a lock before checking permissions in RangeVarGetRelidExtended(),
but in pg_prewarm() and this stats code, we are taking the lock first.
pg_prewarm() can't use RangeVarGetRelid because you give it the OID, but
I'm not seeing why stat_utils.c can't use it.  We should probably fix this.
I wouldn't be surprised if there are other examples.

-- 
nathan

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Should we update the random_page_cost default value?
Next
From: Robert Haas
Date:
Subject: compiling pg_bsd_indent