Re: get rid of RM_HEAP2_ID - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: get rid of RM_HEAP2_ID
Date
Msg-id aOhznflGkNKQ4Mho@paquier.xyz
Whole thread Raw
In response to Re: get rid of RM_HEAP2_ID  (John Naylor <johncnaylorls@gmail.com>)
List pgsql-hackers
On Thu, Oct 09, 2025 at 03:15:11PM +0700, John Naylor wrote:
> Leaving that up to the rmgr makes sense. One consideration I didn't
> mention was for xlogstats.c -- "record_stats[rmid][recid]" would get
> 16x larger if recid could take up the full byte. Maybe that's
> harmless, but I didn't want to assume. Any thoughts on that?

I've missed this interaction, thanks for mentioning it.  XLogStats is
a local state that's only used by pg_walinspect and pg_waldump, so
this extra memory consumed does worry me much; this stuff interacts
with no critical paths.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`
Next
From: jian he
Date:
Subject: Re: speedup COPY TO for partitioned table.