Remove unused struct fields - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Remove unused struct fields
Date
Msg-id aScUuBSawPWogUxs@ip-10-97-1-34.eu-west-3.compute.internal
Whole thread Raw
Responses Re: Remove unused struct fields
List pgsql-hackers
Hi hackers,

Here are a few fields that are not used.

1) username in scram_state:

Added and used in 818fd4a67d61.
Usage removed in f3049a603a7.

2) mask in PgAioWorkerSubmissionQueue:

Added in and not used since 247ce06b883d.

3) write_page in SharedTuplestoreAccessor:

Added in and not used since ab9e0e718acb.

Those have been found with a coccinelle script [1].

Note that it generates a lot of false positives and requires careful manual
review. I'll try to improve it if time permits.

[1]: https://github.com/bdrouvot/coccinelle_on_pg/blob/main/misc/unused_struct_fields.cocci

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: macOS - Sequoia CI task is stuck on the Postgres Github CI
Next
From: Nathan Bossart
Date:
Subject: Re: Remove unused struct fields