Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp
Date
Msg-id aSjwz7scT0J-2FxY@paquier.xyz
Whole thread Raw
In response to Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp  (Amit Langote <amitlangote09@gmail.com>)
List pgsql-hackers
On Thu, Nov 27, 2025 at 06:18:32PM +0900, Amit Langote wrote:
> On Thu, Nov 27, 2025 at 4:58 PM Amul Sul <sulamul@gmail.com> wrote:
>> One question: Regarding date2timestamp_no_overflow(), should we rename
>> it to date2double? We can't use date2timestamp_safe because we already
>> have that function. The renaming is relevant because this function
>> converts a date to the double data type, which allows us to remove the
>> "_no_overflow" extension.
>
> Makes sense to me.

Yes, it would be nice to change all this area at once to remain
consistent across the board.  date2timestamp_no_overflow() is the last
"no_overflow" routine in date.h.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Peter Smith
Date:
Subject: Simplify code building the LR conflict messages