On Thu, Dec 04, 2025 at 04:38:40PM +0530, VASUKI M wrote:
> This v6 series is squashed and rebased on the current master. It also
> includes the revisions and clarifications suggested in the previous round
> of review, including Michael’s comments.
Including the changes in ./configure is not mandatory for patch
authors, as this is something that committers take care of. Still,
these are useful for the CI and testing the ./configure code.
> I agree with the approach of keeping the coverage
> condition local to each build system rather than relying on
> enable_coverage as
> an environment variable. In practice, autoconf (enable_coverage) and Meson
> (b_coverage) expose their coverage settings independently, so duplicating
> the
> check avoids any accidental cross-build inconsistencies. It also prevents
> the
> script from having to detect build-system-specific flags internally, keeping
> libpq-check.pl focused only on symbol inspection. So I think it makes sense
> for Makefile and Meson to each guard their own invocation. What do you
> think?
The only differences I can see between v5 and v6 is that the perl
script uses whitespaces for its code indentation rather than tabs,
which I guess is not expected. Most of the diffs between v6 and v5 go
away once a perl indentation is applied.
I am not going to take a bet on this one on a Friday, so let's give it
a few more days. Have others any comments and/or concerns?
--
Michael
