On Mon, Dec 08, 2025 at 10:11:08AM +0530, VASUKI M wrote:
> Regarding the whitespace comment - I had already ran the pgperltidy on the
> perl script libpq-check.pl before sending the patch,and I also verified the tab
> indentation with cat -T to ensure the tabs were being used.FS,The current version of
> the scripts in v6 should already follow the standard pgindent/pgperltidy formatting
>
> If there is still any specific section that appears mis-indented on your
> side, please let me know and I will adjust it.
The only documentation that I have been following on this matter
exists in src/tools/pgindent/README. That may be an issue with your
environment, I cannot say for sure. And I am pretty sure that my
environment is handling things the way the README tells.
Anyway, after more review of the refactoring patch, I have noticed
that we were losing quite a few details about the reasons why we are
doing things the way they are.
So I have added more details about to keep things a maximum consistent
with what we had documented:
- The shared library check requirement, mentioning that the check is
skipped for static libraries in the Makefile case (for meson, we use
libpq_so, so that did not seem strongly necessary to add there,
perhaps we should).
- The explanation for __cxa_atexit, related to OpenBSD, reusing the
same wording as previously, but in the script.
- The explanation for __tsan_func_exit with ThreadSanitizer, reusing
the same wording as previously, but in the script.
Then applied the result as 4a8e6f43a6b5. Running the check for meson
may bring some surprises, but we'll see. The buildfarm looks OK for
the moment. Once we are completely in the clear, let's move on with
the second patch.
--
Michael
